[ https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694756#action_12694756 ] Kevin Clark commented on THRIFT-276: ------------------------------------ This generally looks fine, and everything passes. I've no objections, just clarifying questions: There's still a bunch of classes in transport.rb and protocol.rb. They look like reasonable things to keep together (Sockets mostly in transport, and errors). Was -- Kevin Clark (JIRA)
↧